SonarLint漏洞及修复01：代码优化

た入场券 2022-11-28 13:53 1140阅读 0赞

> <table> 
>  <tbody> 
>   <tr> 
>    <td><strong>Sonar常见问题及修改建议2020(持续更新)</strong></td> 
>    <td><strong><a href="https://blog.csdn.net/libusi001/article/details/103717457" rel="nofollow">https://blog.csdn.net/libusi001/article/details/103717457</a></strong></td> 
>   </tr> 
>  </tbody> 
> </table>
> 
> **目录**
> 
> 1、Use try-with-resources or close this “BufferedOutputStream“ in a “finally“ clause.
> 
> 2、SonarLint: Replace the type specification in this constructor call with the diamond operator ("<>").Explicit type argument BzbxDataInfos can be replaced with <>
> 
> 3、Type may be primitive
> 
> 4、变量名【ohMYGOd】不符合lowerCamelCase命名风格
> 
> 5、SonarLint: Remove this empty statement.Unnecessary semicolon ';'
> 
> 6、SonarLint: Define a constant instead of duplicating this literal "xxx" 3 times. \[+3 locations\]
> 
> 7、simplify简化
> 
> 8、if(1=null)
> 
> 9、SonarLint: Iterate over the "entrySet" instead of the "keySet"
> 
> 10、Casting 'LoggerFactory.getLogger(...)' to 'Logger' is redundantSonarLint: Remove this unnecessary cast to "Logger".
> 
> 11、A “NullPointerException” could be thrown; “document” is nullable here.
> 
> 12、SonarLint: Save and re-use this "Random".
> 
> 13、SonarLint: Use the built-in formatting to construct this argument.
> 
> --------------------
> 
> ### 1、Use try-with-resources or close this “BufferedOutputStream“ in a “finally“ clause. ###
> 
>     使用try-with-resources或在“ finally”子句中关闭此“ BufferedOutputStream”。
> 
> [https://blog.csdn.net/libusi001/article/details/103848922][https_blog.csdn.net_libusi001_article_details_103848922]
> 
> ### 2、SonarLint: Replace the type specification in this constructor call with the diamond operator ("<>").   Explicit type argument BzbxDataInfos can be replaced with <> ###
> 
>     SonarLint：用菱形运算符（“ <>”）替换此构造函数调用中的类型规范。
>     显式类型参数BzbxDataInfos可以替换为<>
> 
> ![20200818112402891.png][]
> 
> ![20200818112604403.png][]
> 
> ### 3、Type may be primitive ###
> 
>     类型可能是原始的
> 
> ![20200818112645445.png][]
> 
> ![2020081811274331.png][]
> 
> ### 4、变量名【ohMYGOd】不符合lowerCamelCase命名风格 ###
> 
> ![20200818113117883.png][]
> 
> ![20200818113056978.png][]
> 
> ### 5、SonarLint: Remove this empty statement.Unnecessary semicolon ';' ###
> 
>     SonarLint：删除此空语句。
>     不必要的分号';'
> 
> ![watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70][]
> 
> ### 6、SonarLint: Define a constant instead of duplicating this literal "xxx" 3 times. \[+3 locations\] ###
> 
>     SonarLint：定义一个常量，而不是将此常量“ xxx”重复3次。 [+3个地点]
> 
> ### 7、simplify简化 ###
> 
> ![20200818114842781.png][]
> 
> ![20200818115522870.png][]
> 
> ![20200818115622127.png][]
> 
> ![20200818115544360.png][]
> 
> ### 8、if(1=null) ###
> 
> 集合判空isEmpty
> 
> ### 9、SonarLint: Iterate over the "entrySet" instead of the "keySet" ###
> 
> ### 10、Casting 'LoggerFactory.getLogger(...)' to 'Logger' is redundant   SonarLint: Remove this unnecessary cast to "Logger". ###
> 
>     将'LoggerFactory.getLogger（...）'强制转换为'Logger'是多余的
>     SonarLint：删除此不必要的强制转换为“记录器”。
> 
> ![20200818122050615.png][]
> 
> ### 11、A “NullPointerException” could be thrown; “document” is nullable here. ###
> 
>     可能抛出“ NullPointerException”； “文档”在此处为空。
> 
> 可能存在空指针异常，需要增加空值检测，加判空
> 
> ### 12、SonarLint: Save and re-use this "Random". ###
> 
>     SonarLint：保存并重复使用此“随机”。
> 
> ![20200818123052612.png][]
> 
> 初次更改为:
> 
> ![watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70 1][]
> 
> 改造后:
> 
> ![watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70 2][]
> 
> ![20200818123653110.png][]
> 
> 验证:重用随机数成功!
> 
> ![watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70 3][]
> 
>     private static Random rand;
>     
>         static {
>             try {
>                 rand = SecureRandom.getInstanceStrong();
>             } catch (NoSuchAlgorithmException e) {
>                 log.info("Exception:{}", e.getMessage());
>             }
>         }
>     
>         private static void demo6() {
>     
>             for (int i = 0; i < 100; i++) {
>                 int random = rand.nextInt(100);
>                 System.out.println("random~~~~~~"+random);
>             }
>     
>         }
> 
> ### 13、SonarLint: Use the built-in formatting to construct this argument. ###
> 
>     SonarLint：使用内置格式来构造此参数。
> 
> ![20200818142347707.png][]
> 
> 改造:
> 
> ![20200818142449983.png][]
> 
> ![20200818142459436.png][]
> 
>     String key = hashMap.get("key");
>             String key2 = hashMap.get("key2");
>             String key3 = hashMap.get("key3");
>             log.info("info:{}", key + key2 + key3);
>     
>             log.info("info:{},{},{}", key, key2, key3);
>     
>             StringBuilder sb = new StringBuilder();
>             log.info("info:{}", sb.append(hashMap.get("key")).append(hashMap.get("key2")).append(hashMap.get("key3")));
> 
> String创建几个对象的问题:
> 
> [https://libusi.blog.csdn.net/article/details/108076501][https_libusi.blog.csdn.net_article_details_108076501]

[https_blog.csdn.net_libusi001_article_details_103848922]: https://blog.csdn.net/libusi001/article/details/103848922
[20200818112402891.png]: /images/20221124/92d0081454964fa7b655e41aa0acb038.png
[20200818112604403.png]: /images/20221124/b0ec35c473694adea767150315273e17.png
[20200818112645445.png]: /images/20221124/3b693eb7ca2642798c4938d0d31936b8.png
[2020081811274331.png]: /images/20221124/6b9be57301e243d98bd0a8c134ea3dd0.png
[20200818113117883.png]: /images/20221124/8fa1e2668936479ea56b223c1f698fe1.png
[20200818113056978.png]: /images/20221124/73f5b68a865a400fa467af5098a38ed8.png
[watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70]: /images/20221124/7fdef72f4d084cab8cbea7d83ea3a1b0.png
[20200818114842781.png]: /images/20221124/f0d3e498afa14b198330b0410bbf7bf2.png
[20200818115522870.png]: /images/20221124/fb4370b34e264f73b377ce305ce8f82f.png
[20200818115622127.png]: /images/20221124/b077e57e9bf942e79febd547b496bc02.png
[20200818115544360.png]: /images/20221124/ceaaa7c7fe8148abb307cffe5f71780e.png
[20200818122050615.png]: /images/20221124/eba6b7c38d18445ba530e8fd001fecd0.png
[20200818123052612.png]: /images/20221124/1bfb649d15d549c184714bbc6f28550a.png
[watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70 1]: /images/20221124/22110e0cafb84a1f9e16fd51e37fe544.png
[watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70 2]: /images/20221124/94138524458c4ebc843a933123cb0f99.png
[20200818123653110.png]: /images/20221124/f7d63275dd8247759bc5739ae24ca629.png
[watermark_type_ZmFuZ3poZW5naGVpdGk_shadow_10_text_aHR0cHM6Ly9ibG9nLmNzZG4ubmV0L2xpYnVzaTAwMQ_size_16_color_FFFFFF_t_70 3]: /images/20221124/0605ecc111ee4bf19e2057f7b06b0a49.png
[20200818142347707.png]: /images/20221124/e3c5c95ad3284579b9aeb38aa1a391c7.png
[20200818142449983.png]: /images/20221124/a02fa0f817cb4ad0847410c081c5e55f.png
[20200818142459436.png]: /images/20221124/a86928df8c1d48e7bfab3ca75d26b552.png
[https_libusi.blog.csdn.net_article_details_108076501]: https://libusi.blog.csdn.net/article/details/108076501